Ensure that each test closes all file descriptors #1768
+77
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
added
the
no-news-is-good-news
LeiGlobus
force-pushed
the
close_all_resources
branch
from
d882b6b to
f63e8ba
Compare
The big add here is the autouse fixture to verify that the before and after file descriptors are in sync after each test has finished. The other hunks are all in service of ensuring the new fixture does not assert.
khk-globus
force-pushed
the
close_all_resources
branch
from
f63e8ba to
b8b35e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big add here is the autouse fixture to verify that the before and after file descriptors are in sync after each test has finished. The other hunks are all in service of ensuring the new fixture does not assert.
Type of change